-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Caller is origin implementation #1991
Open
ramirez7358
wants to merge
49
commits into
use-ink:master
Choose a base branch
from
CoinFabrik:caller_is_origin-implementation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Caller is origin implementation #1991
ramirez7358
wants to merge
49
commits into
use-ink:master
from
CoinFabrik:caller_is_origin-implementation
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # crates/env/src/lib.rs # crates/env/src/reflect/event.rs # crates/ink/codegen/Cargo.toml
Moved reflection, contract, arithmetic, and miscellaneous types from ink_env to ink_primitives.
This reverts commit 2d1950a.
…tation # Conflicts: # crates/engine/src/database.rs
…rigin-implementation'
ramirez7358
requested review from
cmichi,
ascjones and
SkymanOne
as code owners
November 14, 2023 14:01
@ramirez7358 Sorry for pinging you only now about all those old PR's. Could you possibly merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #_
cargo-contract
orpallet-contracts
?Description
Function
caller_is_origin()
Initial status
Not implemented in integration test
Issue documentation & test case
https://github.com/CoinFabrik/on-ink-integration-tests/tree/main/test-cases/caller-is-origin
Implementation note
We have added the
depth
field to theExecContext
struct in order to be able to detect caller chages avery time calls are made between contracts.Basically every time the callee changes in the
instantiate_contract
orinvoke_contract
function calls, one is aded todepth
. And when the callee returns to the previous one, 1 is subtracted.The
caller_is_origin()
function compares the value ofdepth
to zero to check if the current contract caller is the origin of the entire call stack.Testing guide
In the directory
integration-tests/set_contract_storage
of the target directory, we include in our pull request a test case showing that the observed implementation difference has been corrected. Note that this test is different from the original test case in our repository, which showed the difference.In order to run the integration tests run:
cargo test
In order to run the e2e tests run:
cargo test -–features e2e-tests
These tests are run separately because we do not need to compare their results.
Checklist before requesting a review
CHANGELOG.md