[ink_e2e] resolve DispatchError error details for dry-runs
#1994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgherveou
approved these changes
Nov 16, 2023
SkymanOne
approved these changes
Nov 16, 2023
crates/e2e/src/contract_results.rs
Outdated
| /// Returns the return value as raw bytes of the message from the dry-run. | ||
| /// | ||
| /// Panics if the dry-run message call failed to execute. | ||
| pub fn return_data(&self) -> &[u8] { |
There was a problem hiding this comment.
can't we decode the data?
There was a problem hiding this comment.
This can already be done constructor_result above. That said I copied this from the CallDryRunResult, and I don't think this is super useful for constructors, so have deleted it.
|
|
||
| /// Transforms a [`ContractResult`] from a dry run into a [`Result`] type, containing | ||
| /// details of the [`DispatchError`] if the dry run failed. | ||
| fn contract_result_to_result<V>( |
There was a problem hiding this comment.
Can't this be more generically be implemented with From trait?
There was a problem hiding this comment.
In this case we need the &self to get the metadata for decoding the DispatchError
🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑These are the results when building the
Link to the run | Last update: Thu Nov 16 17:30:11 CET 2023 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1994 +/- ##
==========================================
+ Coverage 53.24% 53.25% +0.01%
==========================================
Files 219 220 +1
Lines 6838 6846 +8
==========================================
+ Hits 3641 3646 +5
- Misses 3197 3200 +3 ☔ View full report in Codecov by Sentry. |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently for dry runs we only get raw dispatch errors e.g.
ModuleError { index: 21, error: [22, 0, 0, 0],. This PR will resolve the error message to a more useful e.g.InstantiateDryRun(DryRunError { debug_message: "", error: Module(ModuleError(<Contracts::StorageDepositNotEnoughFunds>)) })The API for executing dry runs will be aligned with the transaction execution methods by returning a top level
Result. The signatures for thedry_runmethods are now:InstantiateDryRunResulthas been added in this PR to encapsulate the returned result, similar to the existingCallDryRunResult.