Linter: Split ink_linting into two libraries
#2032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split `ink_linting` to `ink_linting_mandatory` and `ink_linting`. Mandatory lints will be integrated in the `cargo-build` build process in use-ink/cargo-contract#1412. Extra lints are optional and could be run by the contract developer to highlight possible issues with secure coding style and to check the compliance with best practices. For more information about this design decision, see: use-ink/cargo-contract#1412 (comment). Closes use-ink#2006
🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑These are the results when building the
Link to the run | Last update: Sun Dec 24 14:26:22 CET 2023 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2032 +/- ##
==========================================
- Coverage 53.85% 53.65% -0.20%
==========================================
Files 221 221
Lines 6958 6965 +7
Branches 3068 3066 -2
==========================================
- Hits 3747 3737 -10
- Misses 3211 3228 +17 ☔ View full report in Codecov by Sentry. |
jubnzv
added a commit
to jubnzv/cargo-contract
that referenced
this pull request
Dec 23, 2023
ink_linting was splitted up to two libraries in use-ink/ink#2032
This is necessary, because the lockfile needs to be updated since we run build with a different `rust-toolchain.yml`.
jubnzv
requested review from
cmichi,
ascjones,
SkymanOne and
a team
as code owners
5 tasks
jubnzv
added a commit
to jubnzv/ink
that referenced
this pull request
Jan 15, 2024
cmichi
added a commit
that referenced
this pull request
Jan 18, 2024
* feat(linter): Automate the generation of documentation for ink-docs This commit introduces a script that extracts documentation from `ink_linting` lints and saves it to the local [ink-docs](https://github.com/paritytech/ink-docs) directory. The markdown formatting of the lints was also improved. * chore(script): Update after #2032 is merged * chore(linter): Wrap in docstring to improve appearance * Update scripts/generate_linter_docs.sh --------- Co-authored-by: Michael Müller <mich@elmueller.net>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2006
cargo-contractorpallet-contracts?Split
ink_lintingtoink_linting_mandatoryandink_linting.Description
Mandatory lints will be integrated in the
cargo-buildbuild process in use-ink/cargo-contract#1412.Extra lints are optional and could be run by the contract developer to highlight possible issues with secure coding style and to check the compliance with best practices.
For more information about this design decision, see: use-ink/cargo-contract#1412 (comment).
Checklist before requesting a review
CHANGELOG.md