-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
call_v2
cross-contract calls with additional limit parameters
#2077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascjones
changed the title
*WIP* support
*WIP* Jan 29, 2024
v2
contract invocation with proof_size_limit
parameterv2
contract invocation with proof_size_limit
parameter
* WIP * Update versions * WIP * WIP migration * WIP * Make test pass * Move e2e tests mod to own file * Update comment * Update example for new e2e API * Update integration-tests/upgradeable-contracts/set-code-hash-migration/lib.rs Co-authored-by: Michael Müller <michi@parity.io> * Top level gitignore * Fix tests update comments * Update upgradeable contracts README.md * spelling --------- Co-authored-by: Michael Müller <michi@parity.io>
This reverts commit bd83e18.
ascjones
changed the title
*WIP*
Feb 2, 2024
v2
contract invocation with proof_size_limit
parametercall_v2
cross-contract calls with additional limit parameters
cmichi
reviewed
Feb 6, 2024
Co-authored-by: Michael Müller <michi@parity.io>
Co-authored-by: Michael Müller <michi@parity.io>
Co-authored-by: Michael Müller <michi@parity.io>
Co-authored-by: Michael Müller <michi@parity.io>
SkymanOne
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Need also to add migration notice in ink-docs
One unrelated test currently failing, should be fixed in #2101 |
Merged
github-merge-queue bot
pushed a commit
to paritytech/polkadot-sdk
that referenced
this pull request
Feb 20, 2024
Remove `#[unstable]` on `call_v2`, `instantiate_v2`, `lock_delegate_dependency` and `unlock_delegate_dependency`. See ink! integrations: - call_v2: use-ink/ink#2077 - instantiate_v2: <TODO> - lock/unlock dependency: use-ink/ink#2076
github-merge-queue bot
pushed a commit
to paritytech/polkadot-sdk
that referenced
this pull request
Feb 20, 2024
Remove `#[unstable]` on `call_v2`, `instantiate_v2`, `lock_delegate_dependency` and `unlock_delegate_dependency`. See ink! integrations: - call_v2: use-ink/ink#2077 - instantiate_v2: <TODO> - lock/unlock dependency: use-ink/ink#2076
paritytech-ci
pushed a commit
to paritytech/polkadot-sdk
that referenced
this pull request
Feb 20, 2024
Remove `#[unstable]` on `call_v2`, `instantiate_v2`, `lock_delegate_dependency` and `unlock_delegate_dependency`. See ink! integrations: - call_v2: use-ink/ink#2077 - instantiate_v2: <TODO> - lock/unlock dependency: use-ink/ink#2076
franciscoaguirre
pushed a commit
to paritytech/polkadot-sdk
that referenced
this pull request
Feb 22, 2024
Remove `#[unstable]` on `call_v2`, `instantiate_v2`, `lock_delegate_dependency` and `unlock_delegate_dependency`. See ink! integrations: - call_v2: use-ink/ink#2077 - instantiate_v2: <TODO> - lock/unlock dependency: use-ink/ink#2076
Merged
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
Remove `#[unstable]` on `call_v2`, `instantiate_v2`, `lock_delegate_dependency` and `unlock_delegate_dependency`. See ink! integrations: - call_v2: use-ink/ink#2077 - instantiate_v2: <TODO> - lock/unlock dependency: use-ink/ink#2076
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires version of
pallet-contracts
includingcall_v2
host function. Introduced in this commitThere is a new host function
call_v2
which allows passing bothWeight
parts:ref_time_limit
andproof_time_limit
and thestorage_deposit_limit
. The legacycall
function only provides the singlegas_limit
parameter, which is used as the value forref_time_limit
.The
call
extrinsic already requires these, so this just brings the cross-contract call API into line with the extrinsic.These parameters can be set on a call builder instance, e.g.
Calling
invoke
will cause the host functionext::call_v2
to be invoked, with the supplied parameters.To call the original
call
host function with just thegas_limit
parameter, call thecall_v1
method on the call builder:Calling
invoke
will cause the host functionext::call
to be invoked, with the supplied parameters.