Skip to content

Conversation

TriplEight
Copy link
Contributor

@TriplEight TriplEight commented Nov 25, 2019

  • sccache now uses redis
  • needs make jobs run right after a dependent job is finished, no more waiting until stage is done.
  • cargo-contract will be updated in 2 example jobs if git version is newer than one installed in docker image. It uses the newest cargo install feature.

@TriplEight TriplEight requested a review from Robbepop November 25, 2019 12:19
@TriplEight TriplEight added the A-CI Continuous integration work item label Nov 25, 2019
@codecov-io
Copy link

codecov-io commented Nov 25, 2019

Codecov Report

Merging #277 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #277   +/-   ##
=======================================
  Coverage   22.51%   22.51%           
=======================================
  Files          37       37           
  Lines        2043     2043           
=======================================
  Hits          460      460           
  Misses       1583     1583

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76c10bd...67dcf56. Read the comment docs.

Copy link
Collaborator

@Robbepop Robbepop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM all in all, please answer my questions and we can merge.

@Robbepop Robbepop changed the title cli is built and sent to examples; cleanup CI CLI is built and sent to examples + cleanup of CI Nov 26, 2019
@TriplEight TriplEight changed the title CLI is built and sent to examples + cleanup of CI Sccache, needs, CLI update Nov 28, 2019
Robbepop
Robbepop previously approved these changes Nov 28, 2019
Copy link
Collaborator

@Robbepop Robbepop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Let's wait for CI to merge.

@TriplEight TriplEight merged commit 0fabc87 into master Nov 28, 2019
@TriplEight TriplEight deleted the cli_installation branch November 28, 2019 19:59
cmichi pushed a commit that referenced this pull request Dec 10, 2019
* cli is built and sent to examples; cleanup CI

* fix artifact location

* fix script

* 'install' cargo-contract

* save before merge

* GIT_DEPTH and some hackery

* typo

* fix artifacts

* test

* test2

* test3

* build contract from it's repo

* typo

* fix build

* build won't work inside git repo. Install --root ftw

* fix build

* fix build n

* fix artifacts

* cleanup and ready to go

* contract is returned to dockerfile

* cargo install should have not given error when version matches

* comment, anchor

* typo

* less dupes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CI Continuous integration work item
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants