Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Lazy::Drop always clear up all its storage #597

Merged
merged 9 commits into from
Nov 27, 2020
Merged

Conversation

cmichi
Copy link
Collaborator

@cmichi cmichi commented Nov 26, 2020

No description provided.

@cmichi cmichi requested a review from Robbepop November 26, 2020 13:20
@codecov-io
Copy link

codecov-io commented Nov 26, 2020

Codecov Report

Merging #597 (74d7747) into master (527e0ac) will decrease coverage by 0.01%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #597      +/-   ##
==========================================
- Coverage   67.28%   67.27%   -0.02%     
==========================================
  Files         155      155              
  Lines        6915     6921       +6     
==========================================
+ Hits         4653     4656       +3     
- Misses       2262     2265       +3     
Impacted Files Coverage Δ
crates/storage/src/collections/stash/tests.rs 100.00% <ø> (ø)
crates/storage/src/collections/vec/tests.rs 100.00% <ø> (ø)
crates/storage/src/lazy/lazy_cell.rs 97.26% <91.66%> (-1.25%) ⬇️
...ates/storage/src/collections/hashmap/fuzz_tests.rs 97.26% <0.00%> (-2.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 527e0ac...715cd1d. Read the comment docs.

crates/storage/src/lazy/lazy_cell.rs Outdated Show resolved Hide resolved
crates/storage/src/lazy/lazy_cell.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@Robbepop Robbepop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Let's wait for CI to approve.

@cmichi cmichi merged commit 2100fa7 into master Nov 27, 2020
@cmichi cmichi deleted the cmichi-fix-lazy-drop branch November 27, 2020 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants