-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[storage] Implement Drop
for Pack
#600
Conversation
dc9c2c2
to
4ee0738
Compare
4ee0738
to
7e40231
Compare
Codecov Report
@@ Coverage Diff @@
## master #600 +/- ##
===========================================
+ Coverage 67.26% 82.44% +15.18%
===========================================
Files 155 155
Lines 6925 6939 +14
===========================================
+ Hits 4658 5721 +1063
+ Misses 2267 1218 -1049
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All in all nice fix and the impl mostly looks good, however, I really wonder about the BinaryHeap
change.
Closes #581.