Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metadata] update scale-info, remove string parameterization #672

Merged
merged 5 commits into from
Feb 5, 2021

Conversation

ascjones
Copy link
Collaborator

@ascjones ascjones commented Feb 2, 2021

Removes the parameterization of scale-info strings, as originally suggested #663 (comment), and further discussed in paritytech/scale-info#58

Temporarily using branch from paritytech/scale-info#59. Once that is merged and included in a new scale-info release I will update this PR and mark it ready for review.

@ascjones
Copy link
Collaborator Author

ascjones commented Feb 4, 2021

This is now waiting on a new scale-info release which is currently blocked by: paritytech/scale-info#65

@ascjones ascjones marked this pull request as ready for review February 5, 2021 15:19
Copy link
Collaborator

@Robbepop Robbepop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Very glad to have this being updated so quickly.

@ascjones ascjones merged commit a526d73 into master Feb 5, 2021
@ascjones ascjones deleted the aj-scale-info-remove-string-parameterization branch February 5, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants