Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spellchecking for examples + Fix master CI #812

Merged
merged 8 commits into from
Jun 9, 2021
Merged

Spellchecking for examples + Fix master CI #812

merged 8 commits into from
Jun 9, 2021

Conversation

cmichi
Copy link
Collaborator

@cmichi cmichi commented Jun 9, 2021

Some miscellaneous improvements and fixes for the nightly clippy errors which currently make the CI fail on master.

@cmichi cmichi requested a review from Robbepop June 9, 2021 08:08
Robbepop
Robbepop reviewed Jun 9, 2021
View reviewed changes
Copy link
Collaborator

@Robbepop Robbepop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all in all LGTM.
How did you notice so many of those (hidden) superflous &?
Was it due to new warnings or clippy lints?

.config/cargo_spellcheck.dic Outdated Show resolved Hide resolved
crates/engine/src/ext.rs Show resolved Hide resolved
crates/storage/src/collections/hashmap/mod.rs Show resolved Hide resolved
examples/erc721/lib.rs Outdated Show resolved Hide resolved
Michael Müller and others added 2 commits June 9, 2021 10:25
@Robbepop
Update examples/erc721/lib.rs
f74412c 
Co-authored-by: Robin Freyler <robin.freyler@gmail.com>
@cmichi
Find solution for words which are non-existent
16ba381
@cmichi
Copy link
Collaborator Author

cmichi commented Jun 9, 2021

How did you notice so many of those (hidden) superflous &?
Was it due to new warnings or clippy lints?

It was new nightly clippy lints! 🚀

@xgreenx xgreenx mentioned this pull request Jun 9, 2021
Merged
@Robbepop Robbepop merged commit 9bda203 into master Jun 9, 2021
@Robbepop Robbepop deleted the cmichi-misc-improvs-0621 branch June 9, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Robbepop Robbepop Robbepop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmichi @Robbepop