Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChainIDE + Polkaholic.io WASM Contract Explorer Integration - Milestone 1 delivery #8

Merged
merged 6 commits into from
Oct 30, 2023

Conversation

sourabhniyogi
Copy link
Contributor

No description provided.

@sourabhniyogi sourabhniyogi changed the title Add Colorful Notion writeup ChainIDE + Polkaholic.io WASM Contract Explorer Integration - Milestone 1 delivery Sep 20, 2023
ChainIDE uses a containerized build process, where tiny variations in configuration may result in different codehashes. This is acceptable for the above security model where ChainIDE is currently assumed to be a trusted IDE. However, to standardize WASM Contract compilation such that multiple parties (in particular Colorful Notion and ChainIDE as well as others) can use identical build processes to derive the exact same code hash, in July 2023 Parity released the following "cargo contract build --verifiable" functionality:
**[https://github.com/paritytech/cargo-contract/releases/tag/v4.0.0-alpha](https://github.com/paritytech/cargo-contract/releases/tag/v4.0.0-alpha)**
The official version is expected to be launched by the end of the year. Both teams researched the usability of this (ChainIDE to incorporate into its build process, Polkaholic to replicate and arrive). See issue [here](TODO).

Copy link
Contributor Author

@sourabhniyogi sourabhniyogi Sep 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wufengtao1 Add link to followup issue here use-ink/cargo-contract#1148

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this PR has been merged

@HCastano
Copy link
Contributor

HCastano commented Oct 6, 2023

Hey, we haven't had time to review this yet, but we'll try to soon 🙇

@TtomaS7 TtomaS7 requested a review from DoubleOTheven October 9, 2023 06:22
|---|---|--|
|Retrieve indexed code hashes by code hash | https://api.polkaholic.io/wasmcode/`{network}` | https://api.polkaholic.io/wasmcode/shiden |
|Retrieve contract addresses | https://api.polkaholic.io/wasmcontracts/`{network}` | https://api.polkaholic.io/wasmcontracts/shibuya |
| Retrieve contract calls of a contract address | https://api.polkaholic.io/wasmcontract/`{network}`/`{contractAddress}` | https://api.polkaholic.io/wasmcontract/shiden/XRcGZzdH841dHySiM62BfJDbQfXXYex3U7LYooRJt8EgJeX |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example URL is throwing a 404 error

Cannot GET /wasmcontract/shiden/XRcGZzdH841dHySiM62BfJDbQfXXYex3U7LYooRJt8EgJeX

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya this is still an issue for me

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


The ChainIDE-Polkaholic unit tests are comprehensively demonstrated in the following video link:

[Comprehensive ChainIDE Walkthrough, including Polkaholic.io integration (Video Link)](https://www.dropbox.com/scl/fi/tf0jgxsmss5b52uk0nbw7/Astar-ChainIDE-M2-New.mp4?rlkey=ts3tpvzvxpbfg7wrl7f4va1yl&dl=0)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super cool 😎

Copy link

@DoubleOTheven DoubleOTheven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very nice. Thanks for the easy-to-follow updates, links, and videos

@TtomaS7 TtomaS7 requested a review from HCastano October 16, 2023 09:19
Copy link
Contributor

@HCastano HCastano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great submission!

Thanks for laying out all the features and providing links and videos, super helpful during my review!

What are the blockers before this can be put into production? I'd love to see developers start to leverage the IDE as well as all the APIs behind it

| 0b. | Polkaholic Documentation | See 0b. Polkaholic Documentation below | See Polkaholic screenshots and URLs |
| 0c. | Testing and Testing Guide | See 0c. below | See ChainIDE video walkthrough |
| 1. | Repository | https://github.com/colorfulnotion/polkaholic | |
| 2. | Repository | https://staging-9589904a8a.chainide.com/s/dashboard/projects | ChainIDE is only semi-open source. This is [the open-source plugin template for ChainIDE](https://github.com/WhiteMatrixTech/chainide-plugin-doc). If you need other open-source plugins, please let us know. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you link to some of the other ink! relevant components of ChainIDE? It's unclear to me what's open-source and what's not

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I come from ChainIDE, and as of now, the only open-source component is the open-source plugin template, allowing users to develop plugins on ChainIDE. However, {the other modules](https://chainide.gitbook.io/chainide-english-1/chainide-modules), including the backend, are not open-source. If you need other parts to be open-source as well, I believe we can discuss the possibility further.

ChainIDE uses a containerized build process, where tiny variations in configuration may result in different codehashes. This is acceptable for the above security model where ChainIDE is currently assumed to be a trusted IDE. However, to standardize WASM Contract compilation such that multiple parties (in particular Colorful Notion and ChainIDE as well as others) can use identical build processes to derive the exact same code hash, in July 2023 Parity released the following "cargo contract build --verifiable" functionality:
**[https://github.com/paritytech/cargo-contract/releases/tag/v4.0.0-alpha](https://github.com/paritytech/cargo-contract/releases/tag/v4.0.0-alpha)**
The official version is expected to be launched by the end of the year. Both teams researched the usability of this (ChainIDE to incorporate into its build process, Polkaholic to replicate and arrive). See issue [here](TODO).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this PR has been merged


The ChainIDE-Polkaholic unit tests are comprehensively demonstrated in the following video link:

[Comprehensive ChainIDE Walkthrough, including Polkaholic.io integration (Video Link)](https://www.dropbox.com/scl/fi/tf0jgxsmss5b52uk0nbw7/Astar-ChainIDE-M2-New.mp4?rlkey=ts3tpvzvxpbfg7wrl7f4va1yl&dl=0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya!

One piece of advice here. I'd split the video out into a series of shorter (1-3min) videos to make it easier for people to find what they need quickly.

I'd also like to see this on YouTube or something more accessible

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good suggestion, and I believe I can have it completed by next week.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya!

One piece of advice here. I'd split the video out into a series of shorter (1-3min) videos to make it easier for people to find what they need quickly.

I'd also like to see this on YouTube or something more accessible

By the way, do you think using the original video directly is sufficient, or do we need to optimize the original video to meet the specifications for the promotional video?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya!

One piece of advice here. I'd split the video out into a series of shorter (1-3min) videos to make it easier for people to find what they need quickly.

I'd also like to see this on YouTube or something more accessible

https://www.youtube.com/watch?v=q-Bf5RHSt4s


1. Try ChainIDE at [https://staging-9589904a8a.chainide.com/s/dashboard/projects](https://staging-9589904a8a.chainide.com/s/dashboard/projects) using Shibuya and the SBY faucet. We recommend using PSP22, PSP34 or the UniswapV2 contract templates, and then using your own WASM Contract.

2. For bug reports and feature requests, submit them [here](TODO) or join our open group here [ChainIDE+Colorful Notion+Astar]()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a TODO linked here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have adjusted it to point to the inkubator matrix room. If you have a better idea, pls advise.

@TtomaS7
Copy link
Contributor

TtomaS7 commented Oct 18, 2023

Hey team!

Here's the form for payment details: https://forms.gle/BUCKfygkiEvpdYna6.
Once you've filled it out, please let me know and be sure to specify what it pertains to; you can include the link to this PR delivery! Further details can be provided under the section: "Please describe which Milestone you have completed and attach the link to the Milestone delivery."

Should you have any questions, don't hesitate to ask. Thank you so much!

Important Note: PLEASE VERIFY YOUR ADDRESS, WHERE YOU WILL RECEIVE THE FUNDS, BEFORE FILLING OUT THE FORM!
For guidance on how to set up identity, refer to this guide.

@wufengtao1
Copy link
Contributor

Hey team!

Here's the form for payment details: https://forms.gle/BUCKfygkiEvpdYna6. Once you've filled it out, please let me know and be sure to specify what it pertains to; you can include the link to this PR delivery! Further details can be provided under the section: "Please describe which Milestone you have completed and attach the link to the Milestone delivery."

Should you have any questions, don't hesitate to ask. Thank you so much!

Important Note: PLEASE VERIFY YOUR ADDRESS, WHERE YOU WILL RECEIVE THE FUNDS, BEFORE FILLING OUT THE FORM! For guidance on how to set up identity, refer to this guide.

Hi, Tomo. I come from ChainIDE. According to the contract, the grant amount is allocated as follows: 120,000 USD Total: 60,000 USD (Colorful Notion), 60,000 USD (ChainIDE). Does this mean that both Colorful and ChainIDE need to fill out this form?

@sourabhniyogi
Copy link
Contributor Author

Hi, Tomo. I come from ChainIDE. According to the contract, the grant amount is allocated as follows: 120,000 USD Total: 60,000 USD (Colorful Notion), 60,000 USD (ChainIDE). Does this mean that both Colorful and ChainIDE need to fill out this form?

@wufengtao1 We did our part [for Colorful Notion], you can do your part [for ChainIDE] -- thanks!

@wufengtao1
Copy link
Contributor

@TtomaS7 @sourabhniyogi ChainIDE has submitted the form for payment details, and the email is wufengtao2@gmail.com :)

@sourabhniyogi
Copy link
Contributor Author

Hey team!

Here's the form for payment details: https://forms.gle/BUCKfygkiEvpdYna6. Once you've filled it out, please let me know and be sure to specify what it pertains to; you can include the link to this PR delivery! Further details can be provided under the section: "Please describe which Milestone you have completed and attach the link to the Milestone delivery."

Should you have any questions, don't hesitate to ask. Thank you so much!

Important Note: PLEASE VERIFY YOUR ADDRESS, WHERE YOU WILL RECEIVE THE FUNDS, BEFORE FILLING OUT THE FORM! For guidance on how to set up identity, refer to this guide.

As per your request, we resubmitted with just 1 address to receive payment for both teams. Thank you!

@sourabhniyogi sourabhniyogi reopened this Oct 20, 2023
@TtomaS7 TtomaS7 added The payment sent! The delivery is successful. The payment sent. and removed Waiting for the payment labels Oct 26, 2023
@TtomaS7
Copy link
Contributor

TtomaS7 commented Oct 26, 2023

You can claim your rewards in 7 days!!
https://polkadot.subsquare.io/treasury/child-bounties/19_462

@TtomaS7 TtomaS7 closed this Oct 26, 2023
@sourabhniyogi
Copy link
Contributor Author

Great submission!

Thanks for laying out all the features and providing links and videos, super helpful during my review!

What are the blockers before this can be put into production? I'd love to see developers start to leverage the IDE as well as all the APIs behind it

@HCastano Can you suggest a non-Astar production path that we can explore with you by the end of the year, which we can address in Milestone 2. Ready to have a "next steps" discussion.

We need to get coordinated on the verification process, PolkaVM, Rococo => ____, and the basic "Who are the top 10 WASM Contract devs who build what that users actually use" question?

@TtomaS7 TtomaS7 reopened this Oct 30, 2023
@TtomaS7 TtomaS7 merged commit 964283c into use-inkubator:master Oct 30, 2023
@HCastano
Copy link
Contributor

@sourabhniyogi Hey sorry, just saw your last message. Is this something that you still need help with?

@sourabhniyogi
Copy link
Contributor Author

sourabhniyogi commented Jan 26, 2024

I believe we should chart

  1. a path for ink!ubator for Coreplay and get coordinated on that.
  2. support ink!/Coreplay on AssetHub [see RFC#66]

@sourabhniyogi sourabhniyogi deleted the colorfulnotion-m1 branch January 26, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
The payment sent! The delivery is successful. The payment sent.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants