src: move shutdown, cleanup, commit from post to after build

[adityamaru]

Important

Move shutdown, cleanup, and commit operations from post-build to after build completion in main.ts, improving error handling and resource management.

• Behavior:
  • Move shutdown, cleanup, and commit operations from post-build to after build completion in main.ts.
  • Handle build success and failure cases immediately after build completion.
• Error Handling:
  • Log buildkitd.log on failure and report build status.
  • Retry unmounting up to 3 times before throwing an error.
• Misc:
  • Remove redundant shutdown and cleanup logic from post-build phase.

^{This description was created by for ac4af62. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to ac4af62 in 45 seconds

More details

• Looked at 114 lines of code in 1 files
• Skipped 2 files when reviewing.
• Skipped posting 3 drafted comments based on config settings.

1. src/main.ts:733

• Draft comment:
  Consider logging the error message when reading the buildkitd.log file fails, similar to the previous implementation, to maintain consistency in error handling.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The error handling for reading the buildkitd.log file is inconsistent. In the new code, it logs a warning and continues, but in the old code, it throws an error. This inconsistency should be addressed.

2. src/main.ts:734

• Draft comment:
  Consider logging the error message when reading the buildkitd.log file fails, similar to the previous implementation, to maintain consistency in error handling.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The error handling for reading the buildkitd.log file is inconsistent. In the new code, it logs a warning and continues, but in the old code, it throws an error. This inconsistency should be addressed.

3. src/main.ts:735

• Draft comment:
  Consider logging the error message when reading the buildkitd.log file fails, similar to the previous implementation, to maintain consistency in error handling.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The error handling for reading the buildkitd.log file is inconsistent. In the new code, it logs a warning and continues, but in the old code, it throws an error. This inconsistency should be addressed.

Workflow ID: wflow_WezVbudpYV3vKJFZ

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

⌛ 2 days left in your free trial, upgrade for $20/seat/month or contact us.