src: add resize2fs call if the block device is formatted #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to f16c36e in 24 seconds
More details
- Looked at
14lines of code in1files - Skipped
2files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. src/main.ts:336
- Draft comment:
Consider handling potential errors fromresize2fsgracefully, similar to how other commands are handled in the code. - Reason this comment was not posted:
Comment looked like it was already resolved.
Workflow ID: wflow_0crtwRbv8FX68ztJ
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
⌛ 1 day left in your free trial, upgrade for $20/seat/month or contact us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add
resize2fscall inmaybeFormatBlockDevice()to ensure ext4 filesystem uses full block device.maybeFormatBlockDevice()inmain.ts, addedresize2fscall when block device is already formatted with ext4 to ensure filesystem uses full block device.This description was created by
for f16c36e. It will automatically update as commits are pushed.