src: fix the movement of cleanup to the main step

[adityamaru]

Important

Refactor build reporting functions to use parameters and update cleanup process in main.ts.

• Behavior:
  • reportBuildCompleted and reportBuildFailed now take blacksmithDockerBuildId and dockerBuildId as parameters instead of using stateHelper.
  • Cleanup process moved to the main step, eliminating build summary generation.
• Functions:
  • getBuilderAddr return type changed to include buildId.
  • reportBuildCompleted and reportBuildFailed updated to use passed parameters.
• Misc:
  • Removed UploadArtifactResponse import from main.ts.

^{This description was created by for 1dee25c. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 4332263 in 23 seconds

More details

• Looked at 271 lines of code in 1 files
• Skipped 2 files when reviewing.
• Skipped posting 5 drafted comments based on config settings.

1. src/main.ts:40

• Draft comment:
  The function reportBuildCompleted now takes additional parameters (blacksmithDockerBuildId, buildRef, dockerBuildDurationSeconds), which improves its flexibility and clarity.
• Reason this comment was not posted:
  Confidence changes required: 0%
  The function reportBuildCompleted now takes additional parameters which are passed correctly. This change improves the function's flexibility and clarity.

2. src/main.ts:94

• Draft comment:
  The function reportBuildFailed now takes additional parameters (dockerBuildId, dockerBuildDurationSeconds), which improves its flexibility and clarity.
• Reason this comment was not posted:
  Confidence changes required: 0%
  The function reportBuildFailed now takes additional parameters which are passed correctly. This change improves the function's flexibility and clarity.

3. src/main.ts:401

• Draft comment:
  The function getBuilderAddr now returns an object with addr and buildId, which improves clarity and future extensibility.
• Reason this comment was not posted:
  Confidence changes required: 0%
  The function getBuilderAddr now returns an object with addr and buildId, which is a good change for clarity and future extensibility.

4. src/main.ts:518

• Draft comment:
  The change from localBuilderAddr to builderInfo is a good refactor for clarity and to accommodate additional information like buildId.
• Reason this comment was not posted:
  Confidence changes required: 0%
  The change from localBuilderAddr to builderInfo is a good refactor for clarity and to accommodate additional information like buildId.

5. src/main.ts:765

• Draft comment:
  The removal of the build summary generation in the post step is a significant change. Ensure that this functionality is not needed elsewhere or is handled differently.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The removal of the build summary generation in the post step is a significant change. Ensure that this functionality is not needed elsewhere or is handled differently.

Workflow ID: wflow_10U8mdx0DTu2tC0a

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

⌛ 1 day left in your free trial, upgrade for $20/seat/month or contact us.

[ellipsis-dev]

👍 Looks good to me! Incremental review on b80dd68 in 22 seconds

More details

• Looked at 279 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 2 drafted comments based on config settings.

1. src/main.ts:645

• Draft comment:
  Ensure that all instances of stateHelper related to dockerBuildDurationSeconds and blacksmithDockerBuildId are removed or updated to use the new parameterized approach to avoid inconsistencies.
• Reason this comment was not posted:
  Comment did not seem useful.

2. src/main.ts:445

• Draft comment:
  Ensure consistent handling of the buildId returned by getBuilderAddr throughout the code to prevent potential issues.
• Reason this comment was not posted:
  Comment did not seem useful.

Workflow ID: wflow_KixIshBsbncQ0VEl

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

⌛ 1 day left in your free trial, upgrade for $20/seat/month or contact us.

[ellipsis-dev]

👍 Looks good to me! Incremental review on 20b0276 in 18 seconds

More details

• Looked at 285 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. src/main.ts:16

• Draft comment:
  The UploadArtifactResponse import is still present but should be removed as per the PR description.
• Reason this comment was not posted:
  Comment did not seem useful.

Workflow ID: wflow_4LML8wsvmvEiu5NH

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

⌛ 1 day left in your free trial, upgrade for $20/seat/month or contact us.

[ellipsis-dev]

👍 Looks good to me! Incremental review on 1dee25c in 22 seconds

More details

• Looked at 288 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 2 drafted comments based on config settings.

1. src/main.ts:770

• Draft comment:
  The cleanup process is still present in the post step, which seems contrary to the PR description stating that cleanup is moved to the main step. Please ensure this is intentional or update the description accordingly.
• Reason this comment was not posted:
  Comment did not seem useful.

2. src/main.ts:714

• Draft comment:
  The code still checks for build summary support, which seems contrary to the PR description stating that build summary generation is removed. Please ensure this is intentional or update the description accordingly.
• Reason this comment was not posted:
  Comment did not seem useful.

Workflow ID: wflow_igGBeKNYscGwmxMS

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

⌛ 1 day left in your free trial, upgrade for $20/seat/month or contact us.

[ellipsis-dev]

⚠️ This PR is too big for Ellipsis, but support for larger PRs is coming soon. If you want us to prioritize this feature, let us know at help@ellipsis.dev