Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github: test npm sticky disk #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

.github: test npm sticky disk #2

wants to merge 1 commit into from

Conversation

adityamaru
Copy link

@adityamaru adityamaru commented Dec 13, 2024

Important

Add GitHub Actions workflow to test Supabase with and without sticky disk, including configuration and SQL scripts for setup.

  • GitHub Actions Workflow:
    • Adds .github/workflows/supabase-demo.yaml to test Supabase with and without sticky disk.
    • github_supabase job runs Supabase without sticky disk on blacksmith-staging.
    • stickydisk_supabase job runs Supabase with sticky disk, setting up sticky disk for ~/.npm, ./node_modules, and /var/lib/docker.
  • Supabase Configuration:
    • Adds config.toml to configure Supabase API, database, studio, and storage settings.
  • Database Setup:
    • Adds migrations/20231214000000_initial_schema.sql to create todos table with row-level security and update trigger.
    • Adds seed.sql to insert initial data into todos table.

This description was created by Ellipsis for 9e93c38. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 0a9c7d8 in 10 seconds

More details
  • Looked at 56 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. .github/workflows/docker-demo.yaml:49
  • Draft comment:
    Add a newline at the end of the file for POSIX compliance.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The workflow is missing a newline at the end of the file, which is a best practice for POSIX compliance.

Workflow ID: wflow_tKBjTTRmNKeEjK55


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@aayushshah15
Copy link

Do you want to add a completely uncached variant as well?

Copy link

cased bot commented Dec 14, 2024

📁 Migrations have been detected in this PR. To split these changes into a separate PR, please visit here.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 3a01a2b in 14 seconds

More details
  • Looked at 103 lines of code in 4 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 drafted comments based on config settings.
1. .github/workflows/supabase-demo.yaml:59
  • Draft comment:
    Add a newline at the end of the file for POSIX compliance.
  • Reason this comment was not posted:
    Confidence changes required: 33%
    The YAML file lacks a newline at the end, which is a best practice for POSIX compliance.
2. supabase/migrations/20231214000000_initial_schema.sql:25
  • Draft comment:
    Add a newline at the end of the file for POSIX compliance.
  • Reason this comment was not posted:
    Confidence changes required: 33%
    The SQL file lacks a newline at the end, which is a best practice for POSIX compliance.
3. supabase/seed.sql:5
  • Draft comment:
    Add a newline at the end of the file for POSIX compliance.
  • Reason this comment was not posted:
    Confidence changes required: 33%
    The SQL file lacks a newline at the end, which is a best practice for POSIX compliance.

Workflow ID: wflow_7ayOWMiXzc9idAkQ


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

cased bot commented Dec 14, 2024

📁 Migrations have been detected in this PR. To split these changes into a separate PR, please visit here.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Incremental review on 508ffba in 39 seconds

More details
  • Looked at 177 lines of code in 4 files
  • Skipped 0 files when reviewing.
  • Skipped posting 4 drafted comments based on config settings.
1. .github/workflows/supabase-demo.yaml:18
  • Draft comment:
    The version 'v4' for 'actions/checkout' does not exist. Use 'v3' instead.
  • Reason this comment was not posted:
    Comment did not seem useful.
2. .github/workflows/supabase-demo.yaml:20
  • Draft comment:
    The version 'v4' for 'useblacksmith/setup-node' does not exist. Use 'v3' instead.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable:
    The comment is about a specific change in the diff, which is the use of 'useblacksmith/setup-node@v4'. The comment claims that 'v4' does not exist, which would be a valid issue if true. However, I need to verify if 'v4' actually exists or not. Without verification, I should assume the comment might be speculative.
    I might be missing the latest information about the 'useblacksmith/setup-node' action versions. It's possible that 'v4' was recently released or is in a pre-release state.
    Given the rules, I should only keep the comment if there is strong evidence that 'v4' does not exist. Without this evidence, the comment should be deleted.
    Delete the comment due to lack of strong evidence that 'v4' does not exist.
3. .github/workflows/supabase-demo.yaml:43
  • Draft comment:
    Consider using a specific version or tag for 'useblacksmith/stickydisk' instead of 'main'.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The YAML file uses 'useblacksmith/stickydisk@main', which might be unstable. It's better to use a specific version or tag.
4. supabase/migrations/20231214000000_initial_schema.sql:25
  • Draft comment:
    Add a newline at the end of the file for POSIX compliance. This applies to other SQL files as well.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The SQL files lack a newline at the end, which is a best practice for POSIX compliance.

Workflow ID: wflow_HYWKJyYnKP00lZtr


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

);

-- Enable Row Level Security
ALTER TABLE todos ENABLE ROW LEVEL SECURITY;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Row-level security is enabled, but no policies are defined. Define policies to make RLS effective.

Copy link

cased bot commented Dec 14, 2024

📁 Migrations have been detected in this PR. To split these changes into a separate PR, please visit here.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 9e93c38 in 8 seconds

More details
  • Looked at 184 lines of code in 4 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. supabase/migrations/20231214000000_initial_schema.sql:25
  • Draft comment:
    Add a newline at the end of the file for POSIX compliance. This is also applicable to supabase/seed.sql.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The SQL files lack a newline at the end, which is a best practice for POSIX compliance and can prevent potential issues with some tools.

Workflow ID: wflow_wbNlx711rUiyTWdp


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants