-
Notifications
You must be signed in to change notification settings - Fork 81
⬆️ Drop Sphinx<7.4, test against Python 3.13 #1447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1447 +/- ##
==========================================
+ Coverage 86.87% 88.54% +1.66%
==========================================
Files 56 60 +4
Lines 6532 7243 +711
==========================================
+ Hits 5675 6413 +738
+ Misses 857 830 -27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
CI fails for Windows only for Python 3.13. Need help or time investigating this. |
023d8ab to
183cea0
Compare
183cea0 to
b057544
Compare
fd3fa04 to
023eed9
Compare
|
Windows problem fixed |
chrisjsewell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments
|
@chrisjsewell please review this again |
get_needs_view())os.path.isabs.test_appfixture to accept a files request parameter to parametrize the src file generation.self.env.relfn2path()Sphinx function forneedimportneeds.json paths.needimportthat also include absolute paths for all OS.This is preliminary work for #1441 in an isolated PR.