Skip to content

Conversation

@ubmarco
Copy link
Member

@ubmarco ubmarco commented Apr 25, 2025

  • Sphinx 7.4 is needed for the write-started event, which is now used to ensure needs post-processing is always run on incremental builds (via a call to get_needs_view())
  • Expanded Python to 3.13. Keeping also 3.12 in the CI as it behaves differently for os.path.isabs.
  • Updated test_app fixture to accept a files request parameter to parametrize the src file generation.
  • Use the self.env.relfn2path() Sphinx function for needimport needs.json paths.
  • Added test cases for needimport that also include absolute paths for all OS.

This is preliminary work for #1441 in an isolated PR.

@codecov
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.54%. Comparing base (4e10030) to head (8939f80).
Report is 127 commits behind head on master.

Files with missing lines Patch % Lines
sphinx_needs/directives/needbar.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1447      +/-   ##
==========================================
+ Coverage   86.87%   88.54%   +1.66%     
==========================================
  Files          56       60       +4     
  Lines        6532     7243     +711     
==========================================
+ Hits         5675     6413     +738     
+ Misses        857      830      -27     
Flag Coverage Δ
pytests 88.54% <94.73%> (+1.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ubmarco ubmarco changed the title ⬆️ Sphinx 8.1, drop Python 3.9 ⬆️ Sphinx 7.4, Python 3.13 Apr 25, 2025
@ubmarco
Copy link
Member Author

ubmarco commented Apr 25, 2025

CI fails for Windows only for Python 3.13. Need help or time investigating this.

@ubmarco ubmarco force-pushed the mh-bump-sphinx-py branch 2 times, most recently from 023d8ab to 183cea0 Compare April 26, 2025 10:56
@ubmarco ubmarco requested a review from chrisjsewell April 26, 2025 10:59
@ubmarco ubmarco marked this pull request as ready for review April 26, 2025 10:59
@ubmarco ubmarco force-pushed the mh-bump-sphinx-py branch from 183cea0 to b057544 Compare April 26, 2025 17:19
@ubmarco ubmarco force-pushed the mh-bump-sphinx-py branch from fd3fa04 to 023eed9 Compare April 29, 2025 19:27
@ubmarco
Copy link
Member Author

ubmarco commented Apr 29, 2025

Windows problem fixed

@ubmarco ubmarco self-assigned this Apr 29, 2025
Copy link
Member

@chrisjsewell chrisjsewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@ubmarco ubmarco requested a review from chrisjsewell April 30, 2025 15:23
@ubmarco
Copy link
Member Author

ubmarco commented May 13, 2025

@chrisjsewell please review this again

@chrisjsewell chrisjsewell changed the title ⬆️ Sphinx 7.4, Python 3.13 ⬆️ Drop Sphinx<7.4, test against Python 3.13 May 14, 2025
@chrisjsewell chrisjsewell merged commit 55eaf91 into master May 14, 2025
18 checks passed
@chrisjsewell chrisjsewell deleted the mh-bump-sphinx-py branch May 14, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants