👌 Improve need part processing #1469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1469 +/- ##
==========================================
+ Coverage 86.87% 88.63% +1.75%
==========================================
Files 56 61 +5
Lines 6532 7277 +745
==========================================
+ Hits 5675 6450 +775
+ Misses 857 827 -30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The `need_part`/`np` role is not a reference and should not use `XRefRole` subclass (see #1437). In addition, the processing now correctly handles and warns on need parts that are not part of a need and `need` roles that reference an unknown part.
chrisjsewell
force-pushed
the
neep-part-improve
branch
from
f228306 to
ed0dbed
Compare
ubmarco
reviewed
Jul 10, 2025
ubmarco
approved these changes
Jul 10, 2025
Member
ubmarco
left a comment
ubmarco
left a comment
There was a problem hiding this comment.
LGTM in general, I just question the re.DOTALL
PierreEtienneJ
pushed a commit
to PierreEtienneJ/sphinx-needs
that referenced
this pull request
Jul 29, 2025
The `need_part`/`np` role is not a reference and should not use an `XRefRole` subclass (see useblocks#1437). In addition, the processing now correctly handles and warns on need parts that are not part of a need and `need` roles that reference an unknown part.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
need_part/nprole is not a reference and should not use anXRefRolesubclass (see #1437).In addition, the processing now correctly handles and warns on need parts that are not part of a need and
needroles that reference an unknown part.