Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prettier needs to be run against repo #197

Closed
brainomite opened this issue Sep 17, 2023 · 3 comments
Closed

Prettier needs to be run against repo #197

brainomite opened this issue Sep 17, 2023 · 3 comments

Comments

@brainomite
Copy link

While adding new features to Bruno, I'm seeing lots of changes from prettier which will make PRs hard to review
helloanoop added a commit that referenced this issue Sep 18, 2023
@helloanoop
feat(#197): prettier formatting on all files in packages/bruno-app
19a7f39
helloanoop added a commit that referenced this issue Sep 18, 2023
@helloanoop
Merge pull request #198 from usebruno/feature/prettier-formatting
b53fcbb 
feat(#197): prettier formatting on all files in packages/bruno-app
@helloanoop
Copy link
Contributor

Done!

@brainomite
Copy link
Author

brainomite commented Sep 19, 2023 •
edited
Loading

I found ~130 more files that would be modified using the husky commit hook if they are worked on. Will do a PR shortly to resolve this

the command I'll be running is npx prettier . --write

helloanoop added a commit that referenced this issue Sep 21, 2023
@helloanoop
chore(#197): ran prettier on packages/bruno-cli
ae692dd
helloanoop added a commit that referenced this issue Sep 21, 2023
@helloanoop
chore(#197): ran prettier on packages/bruno-electron
67fe264
helloanoop added a commit that referenced this issue Sep 21, 2023
@helloanoop
chore(#197): ran prettier on packages/bruno-graphql-docs
a53dd76
helloanoop added a commit that referenced this issue Sep 21, 2023
@helloanoop
chore(#197): ran prettier on packages/bruno-js
5af2f68
helloanoop added a commit that referenced this issue Sep 21, 2023
@helloanoop
chore(#197): ran prettier on packages/bruno-lang
116e050
helloanoop added a commit that referenced this issue Sep 21, 2023
@helloanoop
chore(#197): ran prettier on packages/bruno-query
f68eacf
helloanoop added a commit that referenced this issue Sep 21, 2023
@helloanoop
chore(#197): ran prettier on packages/bruno-schema
88c16fa
helloanoop added a commit that referenced this issue Sep 21, 2023
@helloanoop
chore(#197): ran prettier on packages/bruno-tauri
9a81793
helloanoop added a commit that referenced this issue Sep 21, 2023
@helloanoop
chore(#197): ran prettier on packages/bruno-testbench
bd07381
helloanoop added a commit that referenced this issue Sep 21, 2023
@helloanoop
chore(#197): ran prettier on tests folder
4531cfc
@helloanoop
Copy link
Contributor

@brainomite I have taken care of this. Let me know if you still see any files that have been missed out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@helloanoop @brainomite