Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

folder showing even after deleting #265

Closed
AyushNigam-1 opened this issue Oct 1, 2023 · 3 comments
Closed

folder showing even after deleting #265

AyushNigam-1 opened this issue Oct 1, 2023 · 3 comments

Comments

@AyushNigam-1
Copy link
Contributor

AyushNigam-1 commented Oct 1, 2023 •
edited
Loading

folder inside collection doesn't get remove from the list even after deleting ,
Screenshot 2023-10-01 145005
I have deleted the Demo folder in the Demo12389 , but it still showing ,
but restarting the application fixes the issue .
AyushNigam-1 added a commit to AyushNigam-1/bruno that referenced this issue Oct 1, 2023
@AyushNigam-1
fixed issue-usebruno#251-&-usebruno#265
cf6ec4e
@AyushNigam-1 AyushNigam-1 changed the title item showing even after deleting folder showing even after deleting Oct 1, 2023
@Beedhan Beedhan mentioned this issue Oct 1, 2023
Closed
helloanoop added a commit that referenced this issue Oct 1, 2023
@helloanoop
Merge pull request #266 from not-known-person/fix-251-265
3d8dee9 
fixed issue-#251-&-#265,
helloanoop added a commit that referenced this issue Oct 1, 2023
@helloanoop
fix(#251, #265): phantoms folders fix on rename/delete needs to be ru…
fcc12fb 
…n only on windows
@helloanoop
Copy link
Contributor

helloanoop commented Oct 1, 2023 •
edited
Loading

Merged!

@not-known-person Thanks for taking caring of this!

The phantom folder issue is only on Windows. This works perfectly fine in mac and linux. I've just added this commit so that this fix is applied only on windows.

On Mac and Linux this might end up with multiple redux updates (likely not harmful), but still choosing not to do it since rename and delete feature is pretty stable on mac and linux.

Also, another debugging tip. When you bring up the app, you can open developer tools and turn on debugging by executing window.__IS_DEV__ = true

On my mac, as you see below in the screenshots I have 3 IPC events. addDir when I added the test directory and upon rename - two subsequent events unlinkDir and addDir which is basically a rename. I am suspecting you are not seeing this in windows.

image

@helloanoop
Copy link
Contributor

This has been released in v0.16.5
You can download the latest version from the website.

Thanks @not-known-person

Closing this issue. Please re-open if the issues still persists.

@AyushNigam-1
Copy link
Contributor Author

Thank you so much for your kind words! It's been a pleasure contributing to the project, and I'm glad I could be of help. I look forward to more opportunities to work together and make the project even better.

@lared lared mentioned this issue Oct 4, 2023
Closed
Scotsoo added a commit to Scotsoo/bruno that referenced this issue Oct 14, 2023
@Scotsoo
Revert "fix(usebruno#251, usebruno#265): phantoms folders fix on rena…
7808a6d 
…me/delete needs to be run only on windows"

This reverts commit fcc12fb.

# Conflicts:
#	packages/bruno-app/src/providers/ReduxStore/slices/collections/actions.js
#	packages/bruno-app/src/utils/common/platform.js
Its-treason added a commit to Its-treason/bruno that referenced this issue Oct 14, 2023
@Its-treason
Revert "fix(usebruno#251, usebruno#265): phantoms folders fix on rena…
0a11a29 
…me/delete needs to be run only on windows"

This reverts commit fcc12fb.
@Scotsoo Scotsoo mentioned this issue Oct 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: folder showing after deleting Beedhan/bruno
2 participants
@helloanoop @AyushNigam-1