-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic Auth header not sent #329
Comments
It works fine for me with version 0.18.0: I just replaced a manually generated "Authorization" (Basic) header with the needed username and password in the "Auth" tab, and I can successfully access a restricted API in one of my apps. Could you try again, or check if you do not have anything else interfering your test, @nico-m-64 ? One other thing, though: when using "Generate code" on this new request, the "Authorization: Basic xxx" header is not included in the "curls". Should I create another issue, @helloanoop ? |
Not working for me either. Previously I was using a pre-request script to set the Authorization header. This works fine and in the timeline I can see the Authorization header passed. Removing this pre-request script and instead using Basic Auth (from the Auth tab) with a username and password the request fails (bad credentials) and in the timeline I don't see the Authorization header at all. |
Yes, it worked for me too in my local tests. But we need to use headers. The current code uses axios inbuilt auth which is resulting in the header not being populated. Here is the part we need to make changes: https://github.com/usebruno/bruno/blob/main/packages/bruno-electron/src/ipc/network/prepare-request.js#L22-L33 I will send out a patch fix for this later tonight.
@l0new4nder3r |
I'm playing with Basic Auth on # Example Works
Does not work
|
@helloanoop should it be done there, or in dedicated step where we interpolate everything afterwards? I submitted the latter in PR. I don't think this is going to help interpolating generated code, as there the only piece of code that's actually being interpolated is the url. |
This has been fixed and released in |
Thanks a lot for the quick fix ! Everything work perfectly 👍 |
Hi,
Just say that you made a very very great tool, hope this open source project will be 🚀 all around the solar system ! Thank you so much for your work.
It seems that the header "Authorization: Basic *****" is not sent when configuring the Auth tab with this type.
Have a nice day
The text was updated successfully, but these errors were encountered: