Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bruno-cli does not support apikey authentication inherited from collection #3511

Closed
2 tasks done
rbonestell opened this issue Nov 19, 2024 · 3 comments · May be fixed by #3839
Closed
2 tasks done

bruno-cli does not support apikey authentication inherited from collection #3511

rbonestell opened this issue Nov 19, 2024 · 3 comments · May be fixed by #3839
Assignees
Labels

Comments

@rbonestell
Copy link
Contributor

I have checked the following:

  • I use the newest version of bruno.
  • I've searched existing issues and found nothing related to my issue.

Describe the bug

Requests created using the UI (bruno-electron) application which implement inherited authentication, from the collection, of apikey type ultimately fail when executed with bruno-cli. It appears the prepare-request.js implementation in bruno-cli is not up to parity with the functionality of bruno-electron.

When running requests and tests of this type with the CLI utility, all requests result in failed authentication.

.bru file to reproduce the bug

No response

Screenshots/Live demo link

Impacted requests simply result in authentication errors because request auth was not inherited properly from the collection. There are no screenshots due to apikey auth inheritance working as expected in the Bruno UI.

@rbonestell rbonestell added the bug Something isn't working label Nov 19, 2024
@ganesh-bruno ganesh-bruno self-assigned this Nov 21, 2024
@ganesh-bruno
Copy link
Collaborator

Hey @rbonestell,

Thanks for reporting this issue.
I was able to reproduce it on my end. We're working on it.

@rbonestell
Copy link
Contributor Author

Thanks for the prompt attention, @ganesh-bruno!

It appears there is a broad disparity between bruno-electron and bruno-cli when it comes to inheriting auth from the collection. I mentioned this in my narrowly-scoped PR #3512 which only addresses adding apikey auth to bruno-cli.

At the moment I'm simply using bruno-cli from my fork and for my requirements it is working to my satisfaction. No hard feelings if my PR is rejected in favor of a more proper and official resolution!

Cheers!

@helloanoop
Copy link
Contributor

Merged the PR - #3802
This will be included in the upcoming release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants