Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Run pre-request and post-response actions when fetching GQL schema #704

Closed
cwilper opened this issue Oct 20, 2023 · 4 comments

Comments

@cwilper
Copy link
Contributor

cwilper commented Oct 20, 2023

Why

In my environment, I need to digitally sign all request payloads, including GQL introspections. Since it's a very custom authentication scheme that is not in wide use, I thought it would be good to use a pre-request script for this. But I discovered that GQL schema fetching doesn't invoke pre-request scripts.

Although my use case doesn't call for it, I know Bruno has pre-request and post-response vars and scripts, so it seems like it would be good to also run those, and treat these requests just like any other request. Can anyone think of downsides to doing that?

Related

Postman's GQL schema auto-fetch does not currently support running Pre-request scripts either, but people clearly want it:

@MatisseHack
Copy link

MatisseHack commented Mar 19, 2024

I'm in the same boat! I handle authentication with a pre-request script, which isn't called when loading a GraphQL schema through introspection. I see there was a PR to resolve this issue, but it still doesn't seem to be working for me 🤔

@jwsloan
Copy link

jwsloan commented May 6, 2024

I agree that this does not seem to work.

@Jackevansevo
Copy link
Contributor

I'm pretty sure there's been a regression since #705 got merged.

I'm on v1.16.1 and currently affected by this.

@helloanoop
Copy link
Contributor

I have merged the PR for the fix.
This is set to go out in the upcoming v1.20.0 release

jwetzell pushed a commit to jwetzell/bruno that referenced this issue Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants