Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autocompletion for headers value #1142

Merged

Conversation

GuillaumeOnepilot
Copy link
Contributor

Description

Created a list of possible mime type for headers value similar to Postman. This could be improved by created a map for specific headers, but I recon it would be difficult to maintain properly

recording.mp4

#1141

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

@Its-treason
Copy link
Member

Looks good! One thing: I would probaly move the mimeTypes.js one folder up into the codemirror folder and rename it to something like autocompleteConstants.js.

@GuillaumeOnepilot
Copy link
Contributor Author

Looks good! One thing: I would probaly move the mimeTypes.js one folder up into the codemirror folder and rename it to something like autocompleteConstants.js.

Make sense I will do it

@GuillaumeOnepilot
Copy link
Contributor Author

@Its-treason Any news on this ?

@helloanoop helloanoop merged commit 0d20469 into usebruno:main Jul 4, 2024
@helloanoop
Copy link
Contributor

Merged!
Thanks for working on this @GuillaumeOnepilot !

jwetzell pushed a commit to jwetzell/bruno that referenced this pull request Aug 2, 2024
* feature: add autocompletion for headers value

* chore: rename file to autocompleteConstants and move it to codemirror utils
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants