Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(code-export): add support to grapqhl #1288

Merged

Conversation

ajubin
Copy link
Contributor

@ajubin ajubin commented Dec 27, 2023

Description

Add support to export GraphQL request into code to complete this issue, more specifically the explanation of the PR is on the issue comment linked down below

#1031 (comment)

What did I do ?

  • Enable dropdown option on gql
  • Fix export of gql request into HAR format
  • Fix issue on content-type header on GQL Request

How did I test it ?

  • I can export a GraphQL request with variables, and the exported code works (tested with bash and httpie)

image

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

.filter((header) => header.enabled)
.map((header) => ({
name: header.name,
value: header.value
}));

// TODO in this PR, make sure that the content type application/json is added to the headers by default
Copy link
Contributor Author

@ajubin ajubin Dec 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why GQL Request don't have the content-type "application/json" by default, Iguess this should be setup somewhere else in the code, as here it seems flaky

@ajubin ajubin changed the title feat(code-export): add support to grapqhl feature(code-export): add support to grapqhl Dec 27, 2023
@webark
Copy link

webark commented May 24, 2024

Is this hung up on anything?

@dtrckd
Copy link

dtrckd commented May 26, 2024

+1 for this PR, thank you.

@ajubin
Copy link
Contributor Author

ajubin commented May 30, 2024

Cant code for the next month, feel free to merge it or modify it

@jeffabailey
Copy link

What happened to this? I can't use Bruno without this feature.

Is help needed? Is there another PR that provides this feature?

@crashingrob
Copy link

Bump, this is literally the only feature preventing me from switching to Bruno

@helloanoop helloanoop merged commit 5889e11 into usebruno:main Sep 25, 2024
2 checks passed
@helloanoop
Copy link
Contributor

Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants