Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] : Add icons and styling to dropdown menus, non-breaking tailwind v3 migration #1359

Closed
wants to merge 8 commits into from

Conversation

bpoulaindev
Copy link
Contributor

@bpoulaindev bpoulaindev commented Jan 10, 2024

Description

Referencing issue #1311
Changes that have been made :

  • Tailwind V3 migration (non-breaking) : added tailwind.config.js config file
  • Added Lucide Icons library
  • Added icons alongside items in menu (see screen record)
  • Added red-ish styling to remove/delete items
Enregistrement.de.l.ecran.2024-01-10.a.11.13.16.mov

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

@helloanoop
Copy link
Contributor

Tailwind css v3 upgrade was merged in #1597
Will review the Icons PR later this week.

@helloanoop
Copy link
Contributor

helloanoop commented Sep 4, 2024

Thank you for taking the time to create and submit this PR, @bpoulaindev.

We’ve already migrated to TailwindV3 in a separate PR. I agree that the Lucide Icons are beautiful and potentially even better than the Tabler Icons. We'll definitely consider an icon upgrade or overhaul as part of #1311.

However, we don't anticipate completing #1311 this year (2024), as we have a number of higher-priority tasks. Given the significant size of this PR and the timeline, the effort required to resolve conflicts doesn’t seem justified at this point, especially since this is not on our roadmap to be worked on in the near future.

For now, I’m closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants