Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add search results count to CodeMirror #1498

Merged

Conversation

brunobragaw8t
Copy link
Contributor

@brunobragaw8t brunobragaw8t commented Jan 31, 2024

Description

This adds a small box that displays the count of search results

Search results count example

Closes #1497

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

@helloanoop helloanoop merged commit 67de396 into usebruno:main Aug 23, 2024
@helloanoop
Copy link
Contributor

Merged! Thanks @brunobragaw8t !

@brunobragaw8t brunobragaw8t deleted the feature/search-results-count branch August 23, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: search results count in request response
2 participants