Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check response type for ResponsePane CodeEditor #196

Merged
merged 3 commits into from
Sep 18, 2023

Conversation

mirkogolze
Copy link
Contributor

@mirkogolze mirkogolze commented Sep 16, 2023

Hi,

currently XML was presented in the response Pane surrounded by quotation marks and so the CodeEditor could not highlight the XML.
I added a check for the response type to check if the result is a JSON. Only then Stringify the JSON.
Before the JSON.stringify ran on XML too and added the quotations marks.

second change:
set the request header content-type only if it is not set by the user in the header variables.

BR
Mirko

@helloanoop helloanoop merged commit a103f41 into usebruno:main Sep 18, 2023
1 check passed
@helloanoop
Copy link
Contributor

Merged!

Many Thanks @mirkogolze !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants