Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: accessibility issue in side bar #1975

Conversation

shrilakshmishastry
Copy link
Contributor

@shrilakshmishastry shrilakshmishastry commented Mar 31, 2024

Description

Fix accessibility issue in side nav bar footer icons

  • Make all svgs hidden to assistive technology and provide proper aria-label
  • Use proper tags to list menus: These are groups/lists of items and provide menus for users to navigate. Hence should be descendent of <ul> and <li> tags with role="menubar" and role="menuitem"
  • fix title accessibility issue, by wrapping bruno icon and text inside a single button rather than 2 different buttons. Here bruno logo acts as decorative. Bruno logo and text together act as the brand name here, they are not separate. Hence clubbed.

Accessibility tree structure

then now
Screenshot 2024-03-31 at 7 57 39 PM Screenshot 2024-03-31 at 7 57 09 PM

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

link to issue

@helloanoop
Copy link
Contributor

@anusreesubash Can you review this please.

@helloanoop
Copy link
Contributor

Thanks for taking the time to work on this @shrilakshmishastry !
We made some updates on top of your changes and it merged as a part of #3130

Closing this PR.

@helloanoop helloanoop closed this Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants