fix(#2122): add specific error status codes #2126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds specific exit status codes to identify different problems programatically
jzorn
changed the title
|
Hey, is there anything I can do to improve this PR to get it merged? :) |
|
Friendly ping :) |
There was a problem hiding this comment.
I second the idea of having more specific result codes or error codes. This has already helped a lot in CI/CD scripting with other tools, so I believe this is also helpful with Bruno CLI.
Please consider my suggestions for changes that might further improve the proposed changes.
Co-authored-by: Andreas Siegel <mail@andreassiegel.de>
Co-authored-by: Andreas Siegel <mail@andreassiegel.de>
Co-authored-by: Andreas Siegel <mail@andreassiegel.de>
Co-authored-by: Andreas Siegel <mail@andreassiegel.de>
Co-authored-by: Andreas Siegel <mail@andreassiegel.de>
Co-authored-by: Andreas Siegel <mail@andreassiegel.de>
Co-authored-by: Andreas Siegel <mail@andreassiegel.de>
Co-authored-by: Andreas Siegel <mail@andreassiegel.de>
Co-authored-by: Andreas Siegel <mail@andreassiegel.de>
Co-authored-by: Andreas Siegel <mail@andreassiegel.de>
Co-authored-by: Andreas Siegel <mail@andreassiegel.de>
Co-authored-by: Andreas Siegel <mail@andreassiegel.de>
|
That's a good improvement. Thanks @andreassiegel! |
andreassiegel
approved these changes
Apr 29, 2024
|
@helloanoop Hey, did you have time to look at this change? Thanks! :) |
|
Anything? :) |
|
Friendly ping :) |
|
Is there anything I missed? Do I need to follow a different process to get a change merged? |
|
Anything @helloanoop ? |
|
Merged. Thank you @jzorn ! Thank you @andreassiegel @lohxt1 for the review. |
jwetzell
pushed a commit
to jwetzell/bruno
that referenced
this pull request
Aug 2, 2024
* fix: add specific error status codes usebruno#2122 This change adds specific exit status codes to identify different problems programatically * feat(usebruno#2122): Document the cli exit status codes * Update packages/bruno-cli/src/constants.js Co-authored-by: Andreas Siegel <mail@andreassiegel.de> * Update packages/bruno-cli/src/constants.js Co-authored-by: Andreas Siegel <mail@andreassiegel.de> * Update packages/bruno-cli/src/commands/run.js Co-authored-by: Andreas Siegel <mail@andreassiegel.de> * Update packages/bruno-cli/src/commands/run.js Co-authored-by: Andreas Siegel <mail@andreassiegel.de> * Update packages/bruno-cli/src/commands/run.js Co-authored-by: Andreas Siegel <mail@andreassiegel.de> * Update packages/bruno-cli/src/commands/run.js Co-authored-by: Andreas Siegel <mail@andreassiegel.de> * Update packages/bruno-cli/src/commands/run.js Co-authored-by: Andreas Siegel <mail@andreassiegel.de> * Update packages/bruno-cli/src/commands/run.js Co-authored-by: Andreas Siegel <mail@andreassiegel.de> * Update packages/bruno-cli/src/commands/run.js Co-authored-by: Andreas Siegel <mail@andreassiegel.de> * Update packages/bruno-cli/src/commands/run.js Co-authored-by: Andreas Siegel <mail@andreassiegel.de> * Update packages/bruno-cli/src/commands/run.js Co-authored-by: Andreas Siegel <mail@andreassiegel.de> * Update packages/bruno-cli/src/commands/run.js Co-authored-by: Andreas Siegel <mail@andreassiegel.de> --------- Co-authored-by: Andreas Siegel <mail@andreassiegel.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds specific exit status codes to identify different problems programatically, fixes #2122
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.