Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#1912) Refactor countRequests function to use getTotalRequestCountInCollection in CollectionSettings/Info/index.js #2140

Merged

Conversation

sanjai0py
Copy link
Member

Description

Fixes #1912

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

@sanjai0py sanjai0py closed this Apr 20, 2024
@sanjai0py sanjai0py deleted the fix/request-count-in-collection-info branch April 20, 2024 06:54
@sanjai0py sanjai0py restored the fix/request-count-in-collection-info branch April 23, 2024 06:31
@sanjai0py sanjai0py reopened this Apr 23, 2024
@helloanoop helloanoop merged commit 963b197 into usebruno:main Jun 21, 2024
6 checks passed
@helloanoop
Copy link
Contributor

Merged. Thanks @sanjai0py !

jwetzell pushed a commit to jwetzell/bruno that referenced this pull request Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong number of requests in collection info
3 participants