Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/api key auth #2478

Merged
merged 15 commits into from
Sep 20, 2024
Merged

Feat/api key auth #2478

merged 15 commits into from
Sep 20, 2024

Conversation

sanjai0py
Copy link
Member

@sanjai0py sanjai0py commented Jun 18, 2024

Description

Resolves: #1005

Screen.Recording.2024-06-19.at.4.53.32.PM.mov

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

- Added the ApiKeyAuth component to handle API Key authentication mode.
- Updated the AuthMode component to include an option for API Key authentication.
- Updated the collections schema to include validation for API Key authentication.
- Updated the collectionsSlice to handle API Key authentication in the Redux store.
- Removed the separate handleKeyChange, handlePlacementChange and handleValueChange functions and consolidated them into handleAuthChange.
@sanjai0py sanjai0py marked this pull request as ready for review June 19, 2024 06:06
@Its-treason
Copy link
Member

The changes to prepareRequest etc. also need to be applied to the CLI

@nikischin
Copy link

Maybe it could be cool to have another Dropdown option:

  • Authorization Header

which adds the key value inside Authorization header instead of creating a new Header entry. This could be easily replicated by setting the key to "Authorization: myAuthKey" but still could be useful to reduce confusion as I personally would have expected if I just selected Header to have a behavior like this.

@LcTrKiD
Copy link

LcTrKiD commented Sep 2, 2024

Is this still on track? Thanks for Bruno app you all :)

@helloanoop helloanoop merged commit 637e534 into usebruno:main Sep 20, 2024
2 checks passed
@helloanoop
Copy link
Contributor

Thanks for this @sanjai0py !

@LcTrKiD
Copy link

LcTrKiD commented Sep 20, 2024

Thanks @sanjai0py! This was a must-have for us.

@hoangquochung1110
Copy link

Thanks @sanjai0py for the contribution

Its-treason pushed a commit to Its-treason/bruno that referenced this pull request Sep 22, 2024
@sanjai0py sanjai0py deleted the feat/api-key-auth branch September 24, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auth: API Key based Auth
7 participants