Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update interpolate function in bruno js #2479

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

lohxt1
Copy link
Collaborator

@lohxt1 lohxt1 commented Jun 18, 2024

Description

this is an extension of the pr #2234

~ updated the current interpolateString function in bruno-js to use the recursive interpolation function
~ added the processEnvVars to the assert runtime context

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

@Its-treason
Copy link
Member

Its-treason commented Jun 18, 2024

Can the handlebars package be removed? I think you deleted all the handlebar Imports.

@helloanoop helloanoop merged commit ca22ad0 into usebruno:main Jun 21, 2024
3 checks passed
@helloanoop
Copy link
Contributor

Merged. Thanks @lohxt1 !

Thanks for the review comments @Its-treason !
I have gone ahead and merged the PR. Please let us know if you had any additional comments on this and we will take it up in a follow-up PR

jwetzell pushed a commit to jwetzell/bruno that referenced this pull request Aug 2, 2024
* update interpolate function in bruno js

* removeed handlebars import, updated validations

* removed handlebars import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants