Feat/client cert types #2482
Merged
Feat/client cert types #2482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietrygamat
reviewed
Jun 18, 2024
| } else if (type === 'pfx') { | ||
| try { | ||
| const pfxFilePath = interpolateString(clientCert?.pfxFilePath, interpolationOptions); | ||
| pfxFilePath = path.isAbsolute(pfxFilePath) ? pfxFilePath : path.join(collectionPath, pfxFilePath); |
There was a problem hiding this comment.
Error reading pfx file TypeError: Assignment to constant variable.
pietrygamat
reviewed
Jun 18, 2024
| httpsAgentRequestFields['cert'] = fs.readFileSync(certFilePath); | ||
| httpsAgentRequestFields['key'] = fs.readFileSync(keyFilePath); | ||
| } catch (err) { | ||
| console.error('Error reading cert/key file', err); |
There was a problem hiding this comment.
These errors should be returned to the user somehow (in a timeline like other types of erros?). In case of missing cert file I simply get an Error: socket hang up, as if no cert was configured at all, which is different than handling invalid cert files, or incorrect passphrase.
pietrygamat
reviewed
Jun 18, 2024
| @@ -76,35 +134,161 @@ const ClientCertSettings = ({ clientCertConfig, onUpdate, onRemove }) => { | |||
| ) : null} | |||
| </div> | |||
| <div className="mb-3 flex items-center"> | |||
| <label className="settings-label" htmlFor="certFilePath"> | |||
| Cert file | |||
| <label className="settings-label" htmlFor="protocol"> | |||
There was a problem hiding this comment.
Should be htmlFor="type"? But the type input is missing id
pietrygamat
approved these changes
Jun 19, 2024
|
Fantastic work @lohxt1 ! Thank you @pietrygamat for reviewing and approving the changes. |
5 tasks
jwetzell
pushed a commit
to jwetzell/bruno
that referenced
this pull request
Aug 2, 2024
* feat: pfx/cert client certificates * ui updates * file tooltip * feat: updated client cert logic * feat: updated validations * const to let * throw error incase of invalid file paths * fix htmlFor label * updated cli error messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
~ an option to choose between pfx and cert/key while adding client certificates
Contribution Checklist: