Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/generate code auth header validation #2490

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Conversation

lohxt1
Copy link
Collaborator

@lohxt1 lohxt1 commented Jun 20, 2024

Description

should inherit auth from collection only if the type is 'inherit'

extension of pr #1792

note: fixes for failing cli tests are part of pr #2485

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

@lohxt1 lohxt1 changed the title fix/pr_1792 generate code auth header validation fix/generate code auth header validation Jun 20, 2024
@helloanoop helloanoop merged commit 929d2b5 into usebruno:main Jun 21, 2024
2 of 3 checks passed
@helloanoop
Copy link
Contributor

Merged. Thanks @lohit-1 !

jwetzell pushed a commit to jwetzell/bruno that referenced this pull request Aug 2, 2024
* geenrate code for request to include collection auth headers only if request auth is of type inherit

* validations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants