Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URL generation bug in postman collection exporter #2496 #2510

Conversation

gtlsgamr
Copy link

Description

This PR fixes an issue mentioned in #2496 where exporting a postman collection which has variables in the url leads to getting only '/' in the place of full URL. Now we have a check for template variables before generating URL hostname so that it does not try to create a URL variable anymore which led to the mentioned error.

BEFORE
Bruno -
image

Postman -
image

AFTER
Postman -
image

Contribution Checklist:

  • [x ] The pull request only addresses one issue or adds one feature.
  • [x ] The pull request does not introduce any breaking changes
  • [x ] I have added screenshots or gifs to help explain the change if applicable.
  • [x ] I have read the contribution guidelines.
  • [x ] Create an issue and link to the pull request.

Check for template variables before generating URL hostname to avoid errors. Update generateHost function to handle template variables correctly.
@helloanoop
Copy link
Contributor

Hey @gtlsgamr !
thanks for taking time to work on this PR.

I am closing this PR as this has already been addressed in #3025

@helloanoop helloanoop closed this Sep 18, 2024
@gtlsgamr gtlsgamr deleted the bugfix/postman-export-urlname-variables-missing branch September 18, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants