Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path parameters when OpenAPI specification is imported (#2513) #2533

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

Madh93
Copy link
Contributor

@Madh93 Madh93 commented Jun 29, 2024

Description

Fixes #2513 to support path parameters when OpenAPI specification is imported.

It replaces all path placeholders enclosed in curly braces with colons when the OpenAPI spec is parsed.

Before

meta {
  name: get -users--id-
  type: http
  seq: 1
}

get {
  url: http://api.example.com/v1/users/{id}
  body: none
  auth: none
}

params:query {
  ~metadata: 
}

params:path {
  id: 
}

After

meta {
  name: get -users--id
  type: http
  seq: 2
}

get {
  url: http://api.example.com/v1/users/:id
  body: none
  auth: none
}

params:query {
  ~metadata: 
}

params:path {
  id: 
}

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

@helloanoop helloanoop merged commit 73ac969 into usebruno:main Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] Request-URL from OpenAPI import contains path parameter with curly brackets instead of colon
2 participants