Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow bru.setNextRequest() on Test Scripts (#2155) #2552

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

BruAlcaraz
Copy link
Contributor

@BruAlcaraz BruAlcaraz commented Jul 3, 2024

Description

Allow the use of bru.setNextRequest() at the test script level
#2155

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

@BruAlcaraz
Copy link
Contributor Author

@helloanoop could you review this fix?

@BruAlcaraz
Copy link
Contributor Author

@Its-treason and @dcoomber Could you guys review this fix?

@BruAlcaraz BruAlcaraz force-pushed the feature/NextRequestOnTestScript branch 3 times, most recently from c62319e to b25141c Compare July 10, 2024 14:45
@BruAlcaraz BruAlcaraz force-pushed the feature/NextRequestOnTestScript branch from b25141c to 6223d2c Compare July 10, 2024 14:46
@BruAlcaraz
Copy link
Contributor Author

@helloanoop, @Its-treason and @dcoomber what would be the next step to get these merged and released?

@Its-treason
Copy link
Member

Its-treason commented Jul 24, 2024

This is all you can do for now, you have to wait for the Maintainer to merge this. CC: @sanjai0py

@helloanoop helloanoop merged commit c99da3a into usebruno:main Jul 25, 2024
@sanjai0py
Copy link
Member

Hey @BruAlcaraz, thanks for taking the time to work on this PR, and thanks @Its-treason for the reviews! This will be released in the next outgoing release (in a week).

@BruAlcaraz BruAlcaraz deleted the feature/NextRequestOnTestScript branch July 30, 2024 13:43
jwetzell pushed a commit to jwetzell/bruno that referenced this pull request Aug 2, 2024
…2552)

Co-authored-by: Alcaraz, Bruno <Bruno.Alcaraz@ulgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants