Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloning a dir now clone also folder.bru files recursively#2593 #2596

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

fgrande
Copy link
Contributor

@fgrande fgrande commented Jul 9, 2024

Description

When cloning a folder, requests and subfolders are cloned too, but not folder.bru files.

Contribution Checklist:

  • [X ] The pull request only addresses one issue or adds one feature.
  • [ X] The pull request does not introduce any breaking changes
  • [ X] I have added screenshots or gifs to help explain the change if applicable.
  • [ X] I have read the contribution guidelines.
  • [ X] Create an issue and link to the pull request.

#2593

Suppose to have this structure. :

.
├── MultiLevelDir
│   ├── FirstLevel
│   │   ├── SecondLevel
│   │   │   ├── Artist Finder 2.bru
│   │   │   └── folder.bru
│   │   └── folder.bru
│   └── folder.bru
├── bruno.json
└── collection.bru

Now, cloning the MultiLevelDir we get also folder.bru files attached to every cloned directory:

├── MultiLevelDir
│   ├── FirstLevel
│   │   ├── SecondLevel
│   │   │   ├── Artist Finder 2.bru
│   │   │   └── folder.bru
│   │   └── folder.bru
│   └── folder.bru
├── MultiLevelDir2
│   ├── FirstLevel
│   │   ├── SecondLevel
│   │   │   ├── Artist Finder 2.bru
│   │   │   └── folder.bru
│   │   └── folder.bru
│   └── folder.bru
├── bruno.json
└── collection.bru

Its-treason added a commit to Its-treason/bruno that referenced this pull request Jul 9, 2024
Copy link
Member

@Its-treason Its-treason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, i would personaly rename the variables and remove the underscore, see: Its-treason@35f5d78

@helloanoop helloanoop merged commit 240d2d0 into usebruno:main Jul 10, 2024
3 checks passed
@helloanoop
Copy link
Contributor

Merged! Thanks @fgrande !

Thanks for the review @Its-treason !

@lohit-1 Please work on a new PR incorporating Timon's feedback

@fgrande
Copy link
Contributor Author

fgrande commented Jul 10, 2024

@Its-treason Thanks for the advice, actually in my work projects I use underscore for local/private variables. I'll remember this for the future, Thanks.

@fgrande fgrande mentioned this pull request Jul 10, 2024
2 tasks
@fgrande fgrande deleted the fg/Issue2593 branch July 10, 2024 11:14
@kkevindev
Copy link

Thanks, this closes issue #2593.

jwetzell pushed a commit to jwetzell/bruno that referenced this pull request Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants