Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enter key not submitting new request form #2630

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

therealrinku
Copy link
Contributor

Description

For some reason, clicking enter on New Request modal doesn't submit the form, I noticed that it happens even on other modals if there are more than 1 input fields. so just added a keydown event to submit the form whenever user clicks "enter"

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

@CptnFizzbin
Copy link

LGTM

Copy link

@devvsakib devvsakib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding the Enter key functionality as a separate function instead of directly embedding it in the form. Though it seems okay, this approach enhances maintainability and readability.

@helloanoop helloanoop merged commit 60a8647 into usebruno:main Aug 5, 2024
3 checks passed
@helloanoop
Copy link
Contributor

Merged! Thanks @therealrinku !

@therealrinku therealrinku deleted the fix/submit-form-on-enter branch August 7, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants