Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for dictionary and use in Welcome page #2819

Conversation

iamsushantk
Copy link
Contributor

@iamsushantk iamsushantk commented Aug 13, 2024

Description

Currently constants are spread all over the codebase.

However, going forward it would be a challenge to maintain these values.

Having dictionary would yield following benefits:

  • All constants used in UI layer are housed together.
  • These values can be reused at multiple places in the application thereby reducing duplication and enhancing consistency.
  • Ability to add languages other than English en when needed.
  • Ability to switch languages can be controlled via Preferences.
  • Refactoring is easy as you need to make change only at one place.

I have used Welcome page to demonstrate its usage.

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

@helloanoop helloanoop merged commit 74b1527 into usebruno:main Aug 14, 2024
2 checks passed
@iamsushantk iamsushantk deleted the feature/add-dictionary-support-and-use-in-welcome-page branch August 14, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants