Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Failed to construct 'URL': Invalid URL everytime the URL is modified #2897

Conversation

pietrygamat
Copy link
Contributor

@pietrygamat pietrygamat commented Aug 22, 2024

Description

A non-parsable URL should be an acceptable state while the text is being typed. The parsing is now aborted, without raising an error.

fixes #2652

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

…fied

A non-parsable URL should be an acceptable state while the text is being typed.
@helloanoop helloanoop merged commit ad388e5 into usebruno:main Aug 27, 2024
2 checks passed
@pietrygamat pietrygamat deleted the bugfix/2652-parse-params-from-incomplete-url branch August 27, 2024 21:18
Its-treason pushed a commit to Its-treason/bruno that referenced this pull request Aug 27, 2024
…fied (usebruno#2897)

* fix: Failed to construct 'URL': Invalid URL everytime the URL is modified

A non-parsable URL should be an acceptable state while the text is being typed.

* chore: path params are returned as empty

---------

Co-authored-by: Anoop M D <anoop.md1421@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to construct 'URL': Invalid URL everytime the URL is modified
3 participants