Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/openapispec empty tag #2935

Merged
merged 3 commits into from
Sep 15, 2024

Conversation

anusreesubash
Copy link
Collaborator

@anusreesubash anusreesubash commented Aug 27, 2024

``# Description

While trying to import collection as openapispec file that contains tags: "" , application throws error saying it is corrupted file
as the app cannot have folder with empty name.

This PR will move the requests with empty tags "" to ungrouped so that these requests will be created directly under the collection.

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.

Here is a sample open api spec that fails import in current implementation:

openapi: 3.0.0
info:
  title: User Management API
  description: API for managing users with create, read, update, and delete operations
  version: 1.0.0
servers:
  - url: https://api.example.com/v1
paths:
  /users:
    get:
      tags:
        - ""
      summary: Retrieve a list of users
      description: Get a list of all users
      responses:
        '200':
          description: A list of users
          content:
            application/json:
              schema:
                type: array
                items:
                  type: object
                  properties:
                    id:
                      type: string
                      example: "123"
                    name:
                      type: string
                      example: "John Doe"
                    email:
                      type: string
                      example: "[john.doe@example.com](mailto:john.doe@example.com)"

@anusreesubash anusreesubash marked this pull request as ready for review August 27, 2024 10:24
@helloanoop helloanoop merged commit f31c997 into usebruno:main Sep 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants