Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved Request Count Calculation and UI Handling in RunCollectionItem #2959

Merged
merged 2 commits into from
Sep 15, 2024
Merged

Improved Request Count Calculation and UI Handling in RunCollectionItem #2959

merged 2 commits into from
Sep 15, 2024

Conversation

anusreesubash
Copy link
Collaborator

@anusreesubash anusreesubash commented Aug 29, 2024 •
edited
Loading

Description

  1. Updated the request count logic to only include http-request and graphql-request types using a new getRequestsCount function. Currently it is calculating the folders too.
  2. Added conditional rendering to display a message when no requests are found and disabled the Run and Recursive Run buttons accordingly.

current implementation:
image

Updated design:
image

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

@anusreesubash anusreesubash marked this pull request as ready for review August 29, 2024 06:14
@helloanoop helloanoop merged commit 721d0e1 into usebruno:main Sep 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lohxt1 lohxt1 Awaiting requested review from lohxt1

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anusreesubash @helloanoop