Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: added bottom border for Table component #3078

Merged

Conversation

Pragadesh-45
Copy link
Contributor

In the Table component created in PR #2641 for the ReorderTable component, the bottom border for the header inside the table was not properly handled. As a result, the bottom border was not visible when there were no values in the Table. In this PR, I have addressed the issue by adding the missing border.

Contribution Checklist:

  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.

Before:
image

After:
image

@helloanoop helloanoop merged commit 776866b into usebruno:main Sep 13, 2024
2 checks passed
@helloanoop
Copy link
Contributor

Merged! Thanks @Pragadesh-45 !

@Pragadesh-45 Pragadesh-45 deleted the style/table-border-reorderTable branch September 13, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants