Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cursor position restoration after URL trimming #3087

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

Pragadesh-45
Copy link
Contributor

fixes: #2978

  • This implements a feature to restore the cursor position after the URL has been trimmed (When actively editing on the Query URL.
  • I have used useRef to access the cursor position and set it only after the URL has been trimmed.

Currently, this issue has been fixed by PR #3082 , but the required behavior is to trim the URL when it is actively changed. The previous PR did not add the capability to trim the URL on unsaved request runs. I believe both of these scenarios can be addressed with the merging of this PR.

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Before:

20240913-0954-02.4890724.mp4

After:

20240913-0956-14.1209373.mp4

@pietrygamat pietrygamat mentioned this pull request Sep 13, 2024
5 tasks
@helloanoop helloanoop merged commit 8856e8e into usebruno:main Sep 14, 2024
2 checks passed
@helloanoop
Copy link
Contributor

Thanks @Pragadesh-45 for taking care of this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cursor Jumps to Start Deleting Character and Space in the Request URL Bar
3 participants