Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add logic to handle saving collection settings on shortcut (preview mode) #3145

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

Pragadesh-45
Copy link
Contributor

fixes: #2219

This PR implements the logic for saving collection-settings using the Ctrl+S or Cmd+S shortcut. It allows users to save the Docs tab even in preview mode, thereby resolving the issue.

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

@helloanoop helloanoop merged commit e019a96 into usebruno:main Sep 20, 2024
2 checks passed
Its-treason pushed a commit to Its-treason/bruno that referenced this pull request Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Collection settings: unsaved changes are not recognized properly
2 participants