Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Accessibility issues on the Welcome page #3173

Merged
merged 5 commits into from
Sep 23, 2024

Conversation

Pragadesh-45
Copy link
Contributor

fixes: #1907

Description

This PR enhances the accessibility of the app, mainly on the Welcome Page. It is an extension of PR #1906.

Changes:

  • Used button elements for the buttons on the Welcome Page.
  • Made the links on the Welcome Page focusable.
  • Provided meaningful labels for the links in the Links section.
  • Added aria-label attributes and roles.

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

shrilakshmishastry and others added 3 commits March 23, 2024 10:41
  - use button tag for collection instead of div
  - hide decorative image for assistive technology
  - give meaningful label to links in Links section
@helloanoop helloanoop merged commit 4ef5534 into usebruno:main Sep 23, 2024
2 checks passed
@helloanoop
Copy link
Contributor

Thanks @Pragadesh-45 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility issues on the Welcome page
3 participants