Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: payload comment with keybinding (cmd/ctrl + /) #3279

Closed
wants to merge 1 commit into from

Conversation

LaxmanChoudhary
Copy link

Description

feat: #1451

  • This feature allows users to quickly comment out unnecessary properties in a JSON payload using the keybindings Cmd + / on macOS and Ctrl + / on Windows and Linux.

  • Introduces vs code styled indenation in comments.

  • Improves prior PR: feat: comment with keybinding (cmd + /) in JSON payload interface #2634

  • Some bugs with prior PR that are fixed.

    • only applicable for macos with Cmd + / binding. - fixed
    • comment gets toggled on selecting multiple lines having commented and non-commented lines. - fixed
bruno_pr_sample.mp4

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

@ramki-bruno
Copy link
Collaborator

Looks like issue solved by this PR is addressed by another PR and there were some regressions on them.
But this PR should finally resolve it. More details on the PR itself.

As you can see in the above mentioned PR, we are using CodeMirror.toggleComment method directly instead of the custom implementation which should be easier to maintain.

But anyways, Thanks @LaxmanChoudhary for your contribution.

I'm closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants