fix: failing to import insomnia collection when username/password in auth is null #3293
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Solves #3294
When a user creates a request in insomnia, and sets the auth to "Basic", Insomnia will set the value of username and password to empty string.
BUT if the request has been imported from an older insomnia export, these values may be null instead of an empty string. Insomnia will not change the null value and persist it for future exports, unless the field is modified. This results in the collection failing to import as it hits a .match condition which is expecting a string value.
Steps to reproduce:
Steps to Resolve:
Below i've attached a screenshot showing the example request, and added the json which is the export of that request. Along with an example of the error
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.