implements req.getPathName()

[tlaloc911]

Description

implements function req.getPathName() in GUI and CLI

Resolves #2480, #1874, #987, #3195

GUI

CLI

$ node ~/dev/bruno/packages/bruno-cli/bin/bru.js run f2/subgoogle.bru 
Running Request 

f2/subgoogle (200 OK) - 372 ms
** PostResponse script **
Execution Mode:cli
Pathname:/home/tom/Documentos/test/Test/f2/subgoogle.bru
** PostResponse script  END **
   ✓ HTTP OK

Requests:    1 passed, 1 total
Tests:       1 passed, 1 total
Assertions:  0 passed, 0 total

Contribution Checklist:

• The pull request only addresses one issue or adds one feature.
• The pull request does not introduce any breaking changes
• I have added screenshots or gifs to help explain the change if applicable.
• I have read the contribution guidelines.
• Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

[nikischin]

Great PR, however I personally feel the chosen name is quite confusing. I would rather expect to get the current path part of the Request URL than the script location. Maybe we could rename it to something more clear. All the related Feature Requests suggested different names, maybe we take one of those or any other.

[varunvora]

Replying to @nikischin

Great PR, however I personally feel the chosen name is quite confusing

I agree

I would rather expect to get the current path part of the Request URL than the script location.

Using a part of the request URL may be complicated. Some APIs use path parameters in the request URL, some have query parameters and some may have special characters. req.url should be good if a script requires the request URL.

I would prefer if the meta object in the bruno request was exposed. That would give the request name with req.meta.name.

[tlaloc911]

Thanks for your feedback @nikischin, @varunvora

For my use case I ended up triming the result of req.getPathName() in script to get relative path + bru name. I think this function could be splitted in two:

req.getRelativePath() ==> Relative path + filename.bru
req.getName() ==> request name wuthout 'bru' extension

base Path is already in:

bru.cwd()

About include them as properties insted of methods I have no preference but previous approved PRs added methods, so I think it is more probable to get this merge as methods.

What do you think?

[nikischin]

I personally don't have any opinion on the implementation, as I did not have the need for this feature yet. However, I guess this is a valuable feature, so I would support it being implemented. I was just trying to recommend renaming it to something more precise.

With getPathName() is it not clear what path is meant. Do we mean the path part of the request URL or the file location path? In this case the second one but honestly, the first one was the first thing for me to come in mind.

That's why I was recommending to rename it, maybe we could use getFilePath() or something to make clear it does not return the request URL.

[varunvora]

@tlaloc911 thanks for your proposal!
I like req.getName() and req.getRelativePath() 👍

[tlaloc911]

hi @helloanoop , what do you thing about this?, your feedback is appreciated

[lohxt1]

@tlaloc911 i'm working on a pr to add req.getName(), bru.getCollectionName() functions. i am thinking of using the below internal var names, prefixed with __bruno__

i just wanted to check if you would be okay with updating the pr if you agree with this pattern

request.__bruno__requestName
request.__bruno__collectionName

cc: @helloanoop

[helloanoop]

@tlaloc911 @nikischin I created a proposal to discuss the API in depth - See #3817

@lohit-bruno I am fairly confident with the req.getName(), req.getFolderName(), req.getCollectionName(). Please proceed with implementation for the same in a separate PR.