Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/ Implement Focusable Buttons in the Generate Code Modal #3310

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Pragadesh-45
Copy link
Contributor

fixes: #3309

Description

This PR implements a feature that handles each language tab in the Generate Code modal as a focusable button. This allows users to switch between languages using both mouse clicks and keyboard navigation (Tab and Enter keys).

Changes:

  • Each language tab now has a role of button.
  • Added aria-pressed to indicate the selected language, improving accessibility for users.
  • Maintained a fixed width of 1000px.

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes.
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Created an issue and linked to the pull request.

Before:

Screen.Recording.2024-10-15.143626.mp4

After:

20241015-1042-52.3976272.mp4

@pull-request-size pull-request-size bot added size/M and removed size/S labels Oct 16, 2024
@Pragadesh-45 Pragadesh-45 marked this pull request as ready for review October 17, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Focusable Buttons in the Generate Code Modal
1 participant